Skip to content

feat(wallet): Non-EVM support#8471

Draft
FrederikBolding wants to merge 2 commits intofeat/wallet-libraryfrom
fb/multichain-accounts-wallet-lib
Draft

feat(wallet): Non-EVM support#8471
FrederikBolding wants to merge 2 commits intofeat/wallet-libraryfrom
fb/multichain-accounts-wallet-lib

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​metamask/​snaps-controllers@​20.0.198100769950
Added@​metamask/​bitcoin-wallet-snap@​1.10.11001008396100
Added@​metamask/​solana-wallet-snap@​2.8.0891008897100
Added@​metamask/​tron-wallet-snap@​1.25.21001009699100

View full report

@socket-security
Copy link
Copy Markdown

Caution

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Block High
Obfuscated code: npm @metamask/solana-wallet-snap is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: packages/wallet/package.jsonnpm/@metamask/solana-wallet-snap@2.8.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/solana-wallet-snap@2.8.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block Medium
Network access: npm @metamask/solana-wallet-snap in module globalThis["fetch"]

Module: globalThis["fetch"]

Location: Package overview

From: packages/wallet/package.jsonnpm/@metamask/solana-wallet-snap@2.8.0

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/solana-wallet-snap@2.8.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

}),
});

// TODO: We only need to delegate here for the SnapKeyring, decide if we wanna do that
Copy link
Copy Markdown
Member

@rekmarks rekmarks Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants