Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
|
@metamaskbot update-pr |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3840 +/- ##
==========================================
+ Coverage 98.47% 98.59% +0.12%
==========================================
Files 429 429
Lines 12421 12417 -4
Branches 1924 1928 +4
==========================================
+ Hits 12231 12242 +11
+ Misses 190 175 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@SocketSecurity ignore npm/markdown-it@14.1.0 @SocketSecurity ignore npm/typedoc@0.28.16 |
|
@SocketSecurity ignore npm/yaml@2.8.2 |
| "packages": { | ||
| "html-webpack-plugin>pretty-error>renderkid>htmlparser2>domelementtype": true, | ||
| "html-webpack-plugin>pretty-error>renderkid>htmlparser2>entities": true | ||
| "html-webpack-plugin>pretty-error>renderkid>css-select>domutils>dom-serializer>entities": true |
There was a problem hiding this comment.
Hmm, it's not obvious to me from the yarn.lock diff why this changed 🤔
There was a problem hiding this comment.
Unsure, but the change seems fine 🤔
There was a problem hiding this comment.
Yeah, the node_modules shape must have changed a bit for whatever reason. So now it is using a more local version to the package 🤔
This enables
typedocfor thesnaps-sdk, and updates some files to categorise entries.Note
Medium Risk
Adds new CI publishing steps that write to the
gh-pagesbranch on main pushes and SDK releases; misconfiguration could overwrite published docs or publish incorrect versions, but no runtime product logic changes.Overview
Adds TypeDoc-based API documentation generation for
@metamask/snaps-sdk(build:docs, newtypedoc.jsoncwithtypedoc-theme-fresh, favicon asset, anddocsoutput ignored in git), and updates JSDoc across the SDK and JSX entrypoints/components to provide TypeDoc modules/categories and better@seelinking.Introduces GitHub Actions automation to publish generated docs to
gh-pages: a newpublish-main-docs.ymlworkflow deploys main-branch docs todocs/staging, and the release workflow now detects SDK version bumps to publish docs todocs/<sdkVersion>and updatedocs/latest. Also includes minor CI/support tweaks (ESLint allows TypeDoc tags; LavaMoat policy updated for dependency graph changes; lockfile updated for new tooling deps).Written by Cursor Bugbot for commit 0c6b683. This will update automatically on new commits. Configure here.