Remove sudo from tee cmd as we're already in sudo cmd mode.#10291
Remove sudo from tee cmd as we're already in sudo cmd mode.#10291BeauSmyth19901 wants to merge 1 commit intoMicrosoftDocs:livefrom
Conversation
|
@BeauSmyth19901 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 60c3398: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Ubuntu ODBC installation include to remove a redundant sudo from a tee command when the instructions have already switched into a root shell via sudo su.
Changes:
- Remove
sudofrom theteeinvocation used to install the Microsoft repository GPG key (Ubuntu 18.04 tab).
|
|
||
| ```bash | ||
| curl https://packages.microsoft.com/keys/microsoft.asc | sudo tee /etc/apt/trusted.gpg.d/microsoft.asc | ||
| curl https://packages.microsoft.com/keys/microsoft.asc | tee /etc/apt/trusted.gpg.d/microsoft.asc |
There was a problem hiding this comment.
This change removes sudo from tee in the Ubuntu 18.04 tab because the preceding step uses sudo su. However, the Ubuntu 20.04 and 22.04 tabs in this same include still use sudo tee for the same key import while also starting with sudo su, so the instructions become inconsistent and the PR title/description reads broader than the actual change. Consider making the same update in the other tabs (or alternatively, drop the sudo su step and keep per-command sudo) so the guidance is consistent.
There was a problem hiding this comment.
@BeauSmyth19901 If you can make the change recommended here, I'll get it merged.
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
Just reading through the docs on this and caught what I think is a possible copy/paste mistake.
Since the steps begin with an invocation of
sudo suI think that means we should be able to invoketeewithout it untilexitis invoked.