making redis wrapper handle nil timer. adding missing regigo api passthroughs#8
making redis wrapper handle nil timer. adding missing regigo api passthroughs#8captncraig wants to merge 1 commit intoMiniProfiler:masterfrom
Conversation
|
The redis package works and is still a good idea? I was planning on removing it because I assumed it was old and busted. But ok. |
|
Umm, to be honest, I just started using it. I kinda needed this pr to even make my first experiments work. If I was doing this from scratch, the "pretend to be the redis package, but do a few things differently" approach would definitely not be my first choice. Perhaps something simple like: would be sufficient. Along with a similarly simple pool wrapper to generate those from a timer: or something along those lines. Would that kind of api make more sense. If you were gonna delete this anyway, should I make a bigger overhaul to that effect? Are there any known users of this package in the wild? |
|
There are no known users (I never even used it). I originally added all the other addon packages to try to make adoption easier, but I was also a new go programmer then. I'd just as soon nuke all the other packages and start over with something more reasonable. Or perhaps just add documentation about correct ways to use redis, if there's no need for a full package or something. |
|
I've invited you for write access to this repo so you can do whatever you want with this PR and stuff. |
currently if I call
conn.DoTimerwith a nil timer (perhaps call is not from a wrapped http request), it will panic. This adds parity with things like profile.StepCutomTiming, which still passthrough if an inappropriate timer is used.Also added some newer additions to redigo.