fix(orders): prevent UUID truncation in listorders table#159
fix(orders): prevent UUID truncation in listorders table#159codaMW wants to merge 1 commit intoMostroP2P:mainfrom
Conversation
Order IDs were being truncated and wrapped across multiple lines making them impossible to copy and use in other commands like takebuy, takesell, cancel etc. Added Absolute column constraint (Width::Fixed(38)) on the Order ID column (index 1) to ensure full UUIDs always display on a single line regardless of terminal width or other column content.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA formatting constraint is added to the Order Id column in the print_orders_table function to enforce a fixed width of 38 via ColumnConstraint, without modifying data processing logic. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Order IDs in the
listorderstable were being truncated and wrappedacross multiple lines, making it impossible to copy and use them in
other commands like
takebuy,takesell,cancel, etc.Example of broken output:
│ ba8b23c0-fbce-4e76-9bf8-37feec1 │
│ 54fa1 │
This caused commands to fail with "invalid group length" errors when
users copied the truncated UUID.
Fix
Added an
Absolutecolumn constraint (Width::Fixed(38)) on theOrder ID column to ensure full UUIDs always display on a single line
regardless of terminal width or payment method column content.
Testing
Tested with
listorders(full list) and filtered views:mostro-cli listorders: all UUIDs on single line ✅mostro-cli listorders -k buy -c usd: all UUIDs on single line ✅takebuycommand: no more truncation errors ✅Summary by CodeRabbit