Skip to content

final step for removal of ConditionsService#1773

Open
rlcee wants to merge 1 commit intoMu2e:mainfrom
rlcee:cs_260321
Open

final step for removal of ConditionsService#1773
rlcee wants to merge 1 commit intoMu2e:mainfrom
rlcee:cs_260321

Conversation

@rlcee
Copy link
Collaborator

@rlcee rlcee commented Mar 24, 2026

The ConditionsService is obsolete and several previous PR's removed the references to it. This PR should be the last step of removing the service itself. There are still two references to ConditionsService as part of a path, and those should remain for now. There should also be no more references to ConditionsHandle. The ConditionsEntity header must remain for use by GlobalConstantsService. There are still references to ConditionsService in other repos, but they have all be declared "won't fix" or "fix as needed later" by repo experts.

@FNALbuild
Copy link
Collaborator

Hi @rlcee,
You have proposed changes to files in these packages:

  • Mu2eInterfaces
  • /
  • ConditionsService

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for b6db422: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at b6db422.

Test Result Details
test with Command did not list any other PRs to include
merge Merged b6db422 at 5b02c13
build (prof) Log file. Build time: 08 min 33 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file. Return Code 1.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 5 files
clang-tidy 0 errors 0 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at b6db422 after being merged into the base branch at 5b02c13.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants