Open
Conversation
Collaborator
Collaborator
|
☀️ The build tests passed at b6db422.
N.B. These results were obtained from a build of this Pull Request at b6db422 after being merged into the base branch at 5b02c13. For more information, please check the job page here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ConditionsService is obsolete and several previous PR's removed the references to it. This PR should be the last step of removing the service itself. There are still two references to ConditionsService as part of a path, and those should remain for now. There should also be no more references to ConditionsHandle. The ConditionsEntity header must remain for use by GlobalConstantsService. There are still references to ConditionsService in other repos, but they have all be declared "won't fix" or "fix as needed later" by repo experts.