Add score averaging and convergence early stop#734
Open
CedricHwong wants to merge 1 commit intoNVIDIA:mainfrom
Open
Add score averaging and convergence early stop#734CedricHwong wants to merge 1 commit intoNVIDIA:mainfrom
CedricHwong wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: CedricHwong <997630814@qq.com>
Collaborator
|
Hi @CedricHwong we dont use GradNAS anymore these days. Can you please share your pruning use case and what improvements you see after this change? |
Contributor
|
same as @kevalmorabia97 's comments. Could you please elaborate your use case and what improvements you observe? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Overview:
This PR extends GradNAS gradient scoring with
(1) optional score averaging
(2) early stopping when gradient scores converge. New search config keys are added with defaults: average_scores, score_convergence_tol, score_convergence_patience, and score_convergence_min_updates. The gradient estimation loop now exits early once all hparam score trackers converge. Unit tests cover the averaging math, convergence boundaries, and disabled-convergence behavior.
Usage
Testing
Before your PR is "Ready for review"
Optimizer/blob/main/CONTRIBUTING.md) and your commits are signed.
Additional Information
N/A