Conversation
Signed-off-by: ynankani <ynankani@nvidia.com>
Signed-off-by: ynankani <ynankani@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis pull request introduces a new LTX-2 QAD (Quantization-Aware Distillation) example for Windows Torch ONNX diffusers. The addition includes a complete training workflow with quantization calibration, knowledge distillation, configuration files, dependencies, and comprehensive documentation. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant LtxvQADTrainer
participant Quantizer as ModelOpt<br/>(Quantizer)
participant Student as Student<br/>Model
participant Teacher as Teacher<br/>Model
participant Checkpoint as Checkpoint<br/>Manager
User->>LtxvQADTrainer: Initialize trainer
LtxvQADTrainer->>Quantizer: Run PTQ calibration
Quantizer->>Student: Calibrate weights
Quantizer-->>LtxvQADTrainer: Calibration complete
LtxvQADTrainer->>Teacher: Load teacher model
LtxvQADTrainer->>Student: Wrap with DistillationModel
LtxvQADTrainer->>Student: Training loop
Student->>Student: Forward pass
Student->>Teacher: Get teacher outputs
Student->>Student: Compute training loss
Student->>Student: Compute distillation loss
Student->>Student: Combined loss backward
LtxvQADTrainer->>Checkpoint: Save checkpoint
Checkpoint->>Checkpoint: Extract amax metadata
Checkpoint->>Checkpoint: Filter keys
Checkpoint->>Checkpoint: Save as safetensors
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
sample QAD example script
Type of change: ? new example
Example script for QAD on diffusion model like ltx-2
Overview: ?
Usage
Testing
Before your PR is "Ready for review"
Additional Information
Summary by CodeRabbit
Documentation
New Features