fix: O(n²) jPath degradation when tag names contain dots#794
Open
dollebrolle wants to merge 1 commit intoNaturalIntelligence:masterfrom
Open
fix: O(n²) jPath degradation when tag names contain dots#794dollebrolle wants to merge 1 commit intoNaturalIntelligence:masterfrom
dollebrolle wants to merge 1 commit intoNaturalIntelligence:masterfrom
Conversation
…contain dots
Replace lastIndexOf(".")-based jPath truncation with a popTagFromJPath
helper that uses the known tag name length, correctly handling dots
within XML tag names.
Member
|
Thanks for your changes. I'm planning to handle it differently. Working on this. will update in few days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
Fixes #793
The
jPathvariable inOrderedObjParser.jsuses.as a separator to track tag hierarchy (e.g.,root.parent.child). When closing tags,lastIndexOf(".")is used to pop back one level. However, when tag names themselves contain dots (e.g.,<applink.ios_url>),lastIndexOf(".")finds the dot within the tag name instead of the hierarchy separator, causing incorrect truncation.This leaves residue in the
jPathstring that accumulates with every dotted tag processed, resulting in O(n²) performance degradation.Changes
Replaced all 6
lastIndexOf(".")-based jPath truncations with apopTagFromJPath(jPath, tagName)helper that uses the known tag name length to compute the exact substring position. Since jPath is always built by appending"." + tagName, we can reverse it precisely without searching for dots.Additionally,
lastTagName(used for unpaired tag detection) is now read fromcurrentNode.tagnameinstead of being parsed from jPath vialastIndexOf(".").Benchmark
No performance regression for standard XML parsing.
Type
Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend
[WIP]in PR title. Your PR will be reviewed when[WIP]will be removed from the PR title.Bookmark this repository for further updates.