Startup hook should implement SlingRepositoryInitializer to propagate#548
Draft
Startup hook should implement SlingRepositoryInitializer to propagate#548
Conversation
kwin
force-pushed
the
feature/convert-startup-hook-into-sling-repository-initializer
branch
from
fd03f45 to
a9a1f23
Compare
kwin
force-pushed
the
feature/convert-startup-hook-into-sling-repository-initializer
branch
from
cfe2b35 to
a4a1d07
Compare
|
SonarCloud Quality Gate failed. |
|
SonarCloud Quality Gate failed. |
ghenzler
reviewed
Nov 9, 2021
| List<String> relevantPathsForInstallation = getRelevantPathsForInstallation(repo); | ||
| LOG.info("Running AcTool with " | ||
| + (relevantPathsForInstallation.isEmpty() ? "all paths" : "paths " + relevantPathsForInstallation) + "..."); | ||
| acInstallationService.apply(null, relevantPathsForInstallation.toArray(new String[relevantPathsForInstallation.size()]), |
Member
There was a problem hiding this comment.
@kwin during the repo initialisation process this method participates, IIRC the SlingRepository will not be available as service yet? (see
Member
Author
There was a problem hiding this comment.
right, this probably requires some refactoring of AcInstallationServiceImpl()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exceptions properly
This closes #545 partially