Merged
Conversation
0fc1f3b to
a29cb18
Compare
|
@kwin there is another restrictions pre-validation in |
a29cb18 to
1c4b417
Compare
Member
Author
Oak takes care of that in https://github.com/apache/jackrabbit-oak/blob/17281282fe82d0f0c4e86d0a42ecfb20bfe404e3/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/accesscontrol/ACL.java#L213 as soon as you try to apply those. Otherwise you face exceptions when using restrictions only available at run-time in cloud (but not at build time). This closes #854
4662ece to
d6dfc43
Compare
|
ghenzler
approved these changes
Oct 7, 2025
| restrictions: | ||
| rep:Glob: /cq:* | ||
| assertedException: InvalidRestrictionsException | ||
|
|
Member
There was a problem hiding this comment.
We should not just remove assertedException but then also the test case with the comment
Member
Author
There was a problem hiding this comment.
For me this test shows that invalid restrictions do no longer lead to exceptions, therefore this is still helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Oak takes care of that in
https://github.com/apache/jackrabbit-oak/blob/17281282fe82d0f0c4e86d0a42ecfb20bfe404e3/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/accesscontrol/ACL.java#L213 as soon as you try to apply those.
Otherwise you face exceptions when using restrictions only available at run-time in cloud (but not at build time).
This closes #854