Conversation
liamhughes
force-pushed
the
release/v0.3.0
branch
from
12add06 to
d512468
Compare
mjhilton
left a comment
mjhilton
left a comment
There was a problem hiding this comment.
All seems fine to me, just one question about the reasoning for one of the env changes, but no reason not to merge unless the answer is funky
| env: | ||
| GITHUB_TOKEN: ${{ github.token }} | ||
| MAVEN_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }} | ||
| MAVEN_CENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }} |
There was a problem hiding this comment.
I'm guessing the package that implements the publish-to-Maven-Central logic changed the environment variable name it's expecting, and so we needed to bring it into alignment here?
There was a problem hiding this comment.
It looks like there was a partial change here after the last successful publish such that the defined environment variable key in the setup-java step no longer lined up with what we were passing in here.
There was a problem hiding this comment.
Ah right, so our config got mismatched. Good pick-up, thanks for fixing. Good to merge 👍
2 participants
Background
Releasing this library is currently a little bit of a manual process.
The release for
0.3.0is completed. This PR contains changes made during that process.Changes to be merged
maven-publish.yml0.3.0-SNAPSHOTto0.4.0-SNAPSHOTautoPublishconfiguration topom.xml