Skip to content

feat: Add favicon to website#139

Open
Joshua-Nweze wants to merge 17 commits intoOne-Language:mainfrom
Joshua-Nweze:Add_favicon
Open

feat: Add favicon to website#139
Joshua-Nweze wants to merge 17 commits intoOne-Language:mainfrom
Joshua-Nweze:Add_favicon

Conversation

@Joshua-Nweze
Copy link

@Joshua-Nweze Joshua-Nweze commented Oct 27, 2022

No description provided.

jbampton
jbampton requested changes Oct 28, 2022
View reviewed changes
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://favicon.io/

https://www.favicon-generator.org/

@jbampton jbampton self-assigned this Oct 28, 2022
@jbampton jbampton added enhancement New feature or request good first issue Good for newcomers labels Oct 28, 2022
@Joshua-Nweze
Copy link
Author

Joshua-Nweze commented Oct 28, 2022 via email

jbampton
jbampton requested changes Oct 28, 2022
View reviewed changes
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a link in the HTML head to the web app manifest

https://stackoverflow.com/questions/62122552/do-i-need-to-place-the-manifest-json-file-at-the-root-of-my-webserver#62122707

jbampton
jbampton reviewed Oct 28, 2022
View reviewed changes
Joshua-Nweze
Joshua-Nweze commented Oct 28, 2022
View reviewed changes
Copy link
Author

@Joshua-Nweze Joshua-Nweze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous and updated codes are the same

jbampton
jbampton reviewed Oct 28, 2022
View reviewed changes
jbampton
jbampton requested changes Oct 28, 2022
View reviewed changes
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file "src" paths in the site.webmanifest are wrong.

Perhaps we need relative links.

You should be testing all this work on your local machine.

jbampton
jbampton requested changes Oct 31, 2022
View reviewed changes
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint / Run pre-commit (pull_request) Failing after 9s

jbampton
jbampton reviewed Feb 7, 2023
View reviewed changes
jbampton
jbampton reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the favicons could be better ?

We have some new one

@jbampton
Copy link
Member

jbampton commented Jun 21, 2023

One Language Logo Square

@BaseMax
Copy link
Member

BaseMax commented Oct 18, 2023

cc @jbampton

@BaseMax
Copy link
Member

BaseMax commented Jan 15, 2024

merge or close?

@BaseMax
Copy link
Member

BaseMax commented Aug 15, 2024

?

@BaseMax
Copy link
Member

BaseMax commented Dec 16, 2024

update

@BaseMax
Copy link
Member

BaseMax commented Jan 20, 2025

This branch is out-of-date with the base branch
Merge the latest changes from main into this branch.
This merge commit will be associated with MaxBaseCode@Gmail.Com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbampton jbampton jbampton requested changes

@BaseMax BaseMax Awaiting requested review from BaseMax BaseMax is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@jbampton jbampton

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Joshua-Nweze @jbampton @BaseMax