Skip to content

Comments

refactor: overhaul time string method to use new java features#59

Open
theEvilReaper wants to merge 2 commits intodevelopfrom
rework/timeMethod
Open

refactor: overhaul time string method to use new java features#59
theEvilReaper wants to merge 2 commits intodevelopfrom
rework/timeMethod

Conversation

@theEvilReaper
Copy link
Contributor

Proposed changes

The getTimeString method in the Strings class relies on a manual mapping to create a time format like HH:MM or HH:MM:SS. This pull request switches that to LocalTime in combination with DateTimeFormatter. The only downside is that time values higher than 24 hours are not supported.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Feb 21, 2026
@theEvilReaper theEvilReaper added the enhancement New feature or request label Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant