-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Integrated example project for Mill into CI task #22702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Integrated example project for Mill into CI task #22702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 12 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/mill-plugin-tests.yaml">
<violation number="1" location=".github/workflows/mill-plugin-tests.yaml:34">
P2: Cache restore-keys prefix does not match the cache key, so saved caches will never restore and builds rerun dependency downloads.</violation>
</file>
<file name="modules/openapi-generator-mill-plugin/example/mill-build/build.mill">
<violation number="1" location="modules/openapi-generator-mill-plugin/example/mill-build/build.mill:26">
P2: FileInputStream opened for properties load is never closed, leaking file descriptors.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
modules/openapi-generator-mill-plugin/example/mill-build/build.mill
Outdated
Show resolved
Hide resolved
The example project uses Mills meta-build to resolve the snapshot version from a properties file. The properties-file is now integrated into `release_version_update.sh`.
730c4fc to
78b9b17
Compare
9feb45c to
673f714
Compare
|
The issue was caused by different behavior in how Maven and Coursier download Artifacts. Thats why the m2-Cache is considered "dangerous" by Coursier. But we need the local m2 cache for the Snapshot build, so the solution is to clear the m2 cache except org/openapitools and then start the mill build which will cause Coursier to download all artifacts to its own cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/mill-plugin-tests.yaml">
<violation number="1" location=".github/workflows/mill-plugin-tests.yaml:24">
P2: Cache key uses undefined env `cache-name`, so restore-only cache will always miss</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
e6e5c28 to
041488b
Compare
enhances #22652
As requested in the first Mill-PR which is already merged, this PR enhances the CI and fixes the Snapshot-Version updates on release.
The example project uses Mills meta-build to resolve the snapshot version from a properties file. The properties-file is now integrated into
release_version_update.sh.Summary by cubic
Adds CI checks for the Mill plugin using the example project and fixes SNAPSHOT version updates during releases. The example now reads the plugin version from version.properties via Mill’s meta-build, which the release script updates.
New Features
Bug Fixes
Written for commit 041488b. Summary will update on new commits.