fix: remove unnecessary @NotNull annotation from path variable#23094
Closed
jorgerod wants to merge 2 commits intoOpenAPITools:masterfrom
Closed
fix: remove unnecessary @NotNull annotation from path variable#23094jorgerod wants to merge 2 commits intoOpenAPITools:masterfrom
jorgerod wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
Contributor
Contributor
|
@wing328 for me thats the right way so approved |
Merged
6 tasks
Member
|
closed via #23096 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23093
PR #21951 added
@NotNullto all@PathVariableparameters in the Spring generator. This is both a breaking change that should not have landed in a minor release, and it is technically unnecessary.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@cachescrubber (2022/02)
@welshm (2022/02)
@MelleD (2022/02)
@atextor (2022/02)
@manedev79 (2022/02)
@javisst (2022/02)
@borsch (2022/02)
@Zomzog (2022/09)
@martin-mfg (2023/08)
cc/ @GregDThomas @wing328 @kolomanschaft
Summary by cubic
Removed unnecessary @NotNull from generated Spring @PathVariable parameters to prevent a breaking change and match Spring’s behavior that path variables are already required. Fixes #23093.
Written for commit b946d44. Summary will update on new commits.