Skip to content

[Spring] Remove @Nullable annotation for NativeWebRequest in Spring controller#23576

Open
jpfinne wants to merge 8 commits intoOpenAPITools:masterfrom
jpfinne:bugfix/missingNullableImportOnSpringController
Open

[Spring] Remove @Nullable annotation for NativeWebRequest in Spring controller#23576
jpfinne wants to merge 8 commits intoOpenAPITools:masterfrom
jpfinne:bugfix/missingNullableImportOnSpringController

Conversation

@jpfinne
Copy link
Copy Markdown
Contributor

@jpfinne jpfinne commented Apr 16, 2026

Avoid compilation error due to missing import for @Nullable annotation put in Spring controllers

Fixes #23581 (Regression coming from introduction of jspecify)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Removed @Nullable from NativeWebRequest in generated Spring controllers to avoid missing org.springframework.lang.Nullable imports with jspecify. Strengthened tests with precise pattern matching (to avoid JsonNullable false positives) and checks for @Nullable imports.

  • Bug Fixes
    • Removed @Nullable from the NativeWebRequest field and constructor param in apiController.mustache.

Written for commit d569455. Summary will update on new commits.

@jpfinne jpfinne marked this pull request as ready for review April 17, 2026 09:09
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/test/java/org/openapitools/codegen/java/assertions/TypeAnnotationsAssert.java">

<violation number="1" location="modules/openapi-generator/src/test/java/org/openapitools/codegen/java/assertions/TypeAnnotationsAssert.java:29">
P2: Import-matching regex is not anchored to the final simple name, so `doesImportAnnotation("Nullable")` can pass on unrelated imports like `JsonNullable` and hide regressions.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [Spring] Nullable annotation not imported in Spring-Boot controllers

1 participant