Update 8.0.x with rust-server from master and remove support for rust-server-deprecated#23582
Draft
dsteeley wants to merge 1 commit intoOpenAPITools:8.0.xfrom
Draft
Update 8.0.x with rust-server from master and remove support for rust-server-deprecated#23582dsteeley wants to merge 1 commit intoOpenAPITools:8.0.xfrom
dsteeley wants to merge 1 commit intoOpenAPITools:8.0.xfrom
Conversation
…-server-deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wing328 I noticed you had the 4th of May on the 8.0.0 release milestone so I'm starting this as a PR to remove the
rust-server-deprecatedgenerator in that release.I think this is as simple as a catchup with
masterand then removing all references to rust-server-deprecated. If that's something you want in a separate PR (i.e. here) please say. I've not yet been part of a major release of openapi-generator and keen to help get that in however you prefer.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Syncs
8.0.xwith the latestrust-serverfrommasterand removes therust-server-deprecatedgenerator. Modernizes the Rust server/client templates with better multipart support, a new CLI, TLS defaults, andhyper1 updates.New Features
bin/cli.rs), runnable withcargo run --bin cli --features=cli.client-tlsfeature (useshyper-tlsorhyper-opensslbased on target).multipart/related) with new request/response templates.feature = "validate") usingserde_valid/validator.hyper1 withhyper-util,http_body_util::BoxBody, andTokioIo; refreshes examples and samples.rust-serversamples.Migration
rust-server-deprecatedwithrust-serverand regenerate.headers::authorization::{Basic, Bearer}andswagger::auth::Authorization.hyper1 types (Incoming,http_body_util::BoxBody,hyper_util::rt::TokioIo,hyper::server::conn::http1).client-tlsif you customize features.--features=cli; enablevalidateif you need runtime validation.Written for commit 2a25cd5. Summary will update on new commits.