Open
Conversation
I've skipped 19 since it's not an lts. No needed changes needed to bump to 20 Server runs, tests pass, yarn is happy
This is the current LTS, so we NEED to get here, but upgrading gives us a couple of problems: 1. ts-standard doesn't jive well with modern typescript, and the mystery of import assertions has only deepened with age. 2. I have therefore moved to the non-deprecated versions of these tools (which leaves us with a tasty >2k lint issues) resolves #473 There are now two choices: Disable the failing rules to get rid of the two thousand lint issues, or simply fix them so we can go forward with modern eslint standards. The rules do appear to relate to newer TS practices, rather than noise caused by adding semicolons or changing every instance of a single quote to a double quote. I will make a seperate branch so we can look at the fixes as opposed to just silencing them
Contributor
Author
|
Ah yes, that was always going to fail in CI. woops |
Contributor
Author
|
@vnugent will need to comment on if there are any ramifications for production that I need to account for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A noisy one for sure. I strongly feel this will be necessary for us since node 18 is end of life and v22 is the next one on the list.
I'd like to slowly enable many of the rules that I have suppressed in the linter config, since many of them represent modern best practice but I will make issues for each one individually so as not to dump too many changes here