Added function to allow for unicasting to specific IP address#23
Open
BlindElephants wants to merge 6 commits intoOpenLightingProject:masterfrom
Open
Added function to allow for unicasting to specific IP address#23BlindElephants wants to merge 6 commits intoOpenLightingProject:masterfrom
BlindElephants wants to merge 6 commits intoOpenLightingProject:masterfrom
Conversation
…rather than broadcasting.
…rather than broadcasting.
…rather than broadcasting.
…mpile libartnet. Must be followed with "make install" to install system-wide
nomis52
reviewed
Jun 3, 2025
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| AM_CFLAGS = -I$(top_builddir) -I$(top_srcdir) -Wall -Werror -Wformat -W | |||
Member
There was a problem hiding this comment.
This seems unrelated. Is there a reason it was removed?
Member
There was a problem hiding this comment.
Created https://github.com/OpenLightingProject/libartnet/pull/25/files which should remove the need for this change.
nomis52
reviewed
Jun 3, 2025
|
|
||
| while (remaining > 0) { | ||
| memset(&tod.data.toddata.tod,0x00, ARTNET_MAX_UID_COUNT); | ||
| memset(&tod.data.toddata.tod,0x00, ARTNET_MAX_UID_COUNT * ARTNET_RDM_UID_WIDTH); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added function to artnet.c/.h that allows for sending artnet messages to a specific IP address. This function otherwise replicates
artnet_send_dmx, while stripping out unnecessary conditionals. The target IP address is provided as a uint32_t as the last argument to the new function. This value can be derived by using theinet_addr()function, as used elsewhere in libartnet and documented here.