fix: correctly check for promise in useLoadData#39
Merged
NielsJPeschel merged 5 commits intomainfrom Jan 31, 2025
Merged
Conversation
NielsJPeschel
commented
Jan 9, 2025
nthurow
reviewed
Jan 10, 2025
NielsJPeschel
commented
Jan 10, 2025
Contributor
Author
There was a problem hiding this comment.
@nthurow Ran this test with how useLoadData was written before (ie using instanceof Promise), and it did in fact fail! I was worried we wouldn't be able to test this scenario adequately, but glad that isn't the case!
NielsJPeschel
commented
Jan 10, 2025
| { | ||
| "name": "@optum/react-hooks", | ||
| "version": "1.0.4", | ||
| "version": "1.0.5-next.1", |
Contributor
Author
There was a problem hiding this comment.
we should start looking at automating this
nthurow
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently,
useLoadDatamakes the assumption a promise is a native promises. Non-native promises lead to a bug where we immediately assignloadedData.resulta promise without ever evaluating that promise.The fix is to go into further depth when checking initial promise.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments