[BugFix][Models] Fix PaddleFormers fallback attention layout and fused QKV loading in mixed weight formats#6465
Open
jackyYang6 wants to merge 1 commit intoPaddlePaddle:developfrom
Open
Conversation
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6465 +/- ##
==========================================
Coverage ? 69.40%
==========================================
Files ? 391
Lines ? 52785
Branches ? 8221
==========================================
Hits ? 36633
Misses ? 13482
Partials ? 2670
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes multiple issues in PaddleFormers fallback path that caused startup/runtime failures or semantic degradation on different environments (local/QA) and weight formats (torch/paddle):
Invalid attention layout.model_format-based behavior for transpose/writeback to avoid silent semantic corruption.qwen2.*vsmodel.*).Modifications
1)
fastdeploy/model_executor/models/paddleformers/base.pyUpdated
fastdeploy_append_attention_forward:local_headscompatible withglobal_headsvia divisibility).Updated fallback
load_weights:resolve_param_name.model_format(torch/paddle) and explicit layout checks.2)
tests/model_executor/test_paddleformers_base.pynum_heads/num_key_value_headsare explicit and stable.Usage or Command
Unit tests
Service startup verification (example)
TP case (example)
Accuracy Tests
This PR affects model forward/weight loading path. Accuracy checks were run on local and QA environments:
local headsvsglobal heads): pass (noInvalid attention layout)Checklist
pre-commitbefore commit.developbranch (not a release cherry-pick PR).