Merged
Conversation
JWhitleyWork
force-pushed
the
16602-jazzy-changes
branch
from
56c2c70 to
57bad45
Compare
JWhitleyWork
force-pushed
the
16602-jazzy-changes
branch
from
57bad45 to
211d76a
Compare
JWhitleyWork
changed the title
Member
Author
|
Tested local builds with |
JWhitleyWork
force-pushed
the
16602-jazzy-changes
branch
3 times, most recently
from
42cdaf3 to
de28087
Compare
Member
Author
|
Humble build looks good too. |
dsobek
reviewed
Feb 23, 2026
..._dependencies/ros2_robotiq_gripper/robotiq_controllers/src/robotiq_activation_controller.cpp
Show resolved
Hide resolved
…ages Use #ifdef ROS_DISTRO_JAZZY preprocessor guards to support both ROS Humble and Jazzy APIs. Changes include: - on_init(HardwareComponentInterfaceParams) for Jazzy vs on_init(HardwareInfo) for Humble - SwitchController field renames (activate/deactivate_controllers vs start/stop_controllers) - ResourceManager constructor with clock and logger params for Jazzy - get_optional<double>().value() replacing deprecated get_value() (removed in Kilted Kaiju) - std::ignore for [[nodiscard]] set_value() returns - ConstSharedPtr subscription callbacks (compatible with both distros) - ROS distro detection via ros_environment buildtool_depend and CMake compile definitions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JWhitleyWork
force-pushed
the
16602-jazzy-changes
branch
from
de28087 to
e31ed9c
Compare
suchkristenwow
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#ifdef ROS_DISTRO_JAZZYpreprocessor guards torobotiq_driver,robotiq_controllers, andmoveit_studio_kinova_pstop_managerso they build on both ROS Humble and ROS Jazzyon_init(HardwareComponentInterfaceParams),SwitchControllerfield renames,ResourceManagerconstructor, deprecatedget_value()/set_value()replacements, andConstSharedPtrsubscription callbacksros_environmentbuildtool dependency and CMake compile definitions to each affected packageNote: Changes to the
clearpath_mecanum_drive_controllerandros2_kortexsubmodules are excluded from this PR and should be submitted separately to their upstream repos.Test plan
robotiq_driverandrobotiq_controllers🤖 Generated with Claude Code