Skip to content

Upgrade to django 4 #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Naramsim merged 5 commits into from
Jan 21, 2026
Merged

Upgrade to django 4 #1373

Naramsim merged 5 commits into from
Jan 21, 2026

Conversation

@Naramsim
Copy link
Member

@Naramsim Naramsim commented Jan 20, 2026

No description provided.

@Naramsim
Copy link
Member Author

Naramsim commented Jan 20, 2026

hi @simonorono could you review this PR? I saw you were the one that migrated Django 2 to Django 3 in the past. This PR migrates to Django 4.

8f716cd

Thanks!

@Naramsim Naramsim requested a review from simonorono January 20, 2026 10:37
phalt
phalt approved these changes Jan 20, 2026
View reviewed changes
Copy link
Member

@phalt phalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, darn we're so far behind!

@Naramsim
Copy link
Member Author

Naramsim commented Jan 20, 2026

It seems easy to upgrade to 5 and 6 though, I'll try in the next days.

@Naramsim Naramsim merged commit a2821c7 into master Jan 21, 2026
9 checks passed
@pokeapi-machine-user
Copy link

pokeapi-machine-user commented Jan 21, 2026

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Jan 21, 2026
@pokeapi-machine-user
[Updater Bot] Regenerate data from PokeAPI/pokeapi#1373
b88fb22
@pokeapi-machine-user pokeapi-machine-user mentioned this pull request Jan 21, 2026
Merged
@pokeapi-machine-user
Copy link

pokeapi-machine-user commented Jan 21, 2026

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Jan 21, 2026
@pokeapi-machine-user
[Updater Bot] Regenerate data from PokeAPI/pokeapi#1373 (#322)
40d4ffe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phalt phalt phalt approved these changes

@simonorono simonorono Awaiting requested review from simonorono

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Naramsim @pokeapi-machine-user @phalt