Skip to content

fix: Terminal layout setting breaking to an empty dropdown #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
charlesvien merged 1 commit into from
Jan 16, 2026
Merged

fix: Terminal layout setting breaking to an empty dropdown #519

charlesvien merged 1 commit into from
Jan 16, 2026

Conversation

@charlesvien
Copy link
Contributor

@charlesvien charlesvien commented Jan 16, 2026

No description provided.

This was referenced Jan 16, 2026
Closed
Merged
Merged
Merged
Merged
@charlesvien Graphite App
Copy link
Contributor Author

charlesvien commented Jan 16, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 16, 2026
Closed
Merged
@charlesvien charlesvien changed the title Implement terminal layout setting breaking to an empty dropdown feat: Implement terminal layout setting breaking to an empty dropdown Jan 16, 2026
@charlesvien charlesvien marked this pull request as ready for review January 16, 2026 11:45
@charlesvien charlesvien requested a review from a team as a code owner January 16, 2026 11:45
@charlesvien charlesvien changed the title feat: Implement terminal layout setting breaking to an empty dropdown Fix: Terminal layout setting breaking to an empty dropdown Jan 16, 2026
@charlesvien charlesvien changed the title Fix: Terminal layout setting breaking to an empty dropdown fix: Terminal layout setting breaking to an empty dropdown Jan 16, 2026
@charlesvien charlesvien force-pushed the 01-15-implement_real_torch branch from aca8d8b to de3fa55 Compare January 16, 2026 17:17
@charlesvien charlesvien force-pushed the 01-15-implement_terminal_layout_setting_breaking_to_an_empty_dropdown branch from 04812d3 to c64a8f1 Compare January 16, 2026 17:17
@charlesvien charlesvien changed the base branch from 01-15-implement_real_torch to graphite-base/519 January 16, 2026 17:32
@charlesvien charlesvien force-pushed the 01-15-implement_terminal_layout_setting_breaking_to_an_empty_dropdown branch from c64a8f1 to 084f54e Compare January 16, 2026 17:33
@charlesvien charlesvien changed the base branch from graphite-base/519 to 01-15-implement_ability_to_choose_key_combination_to_send_messages January 16, 2026 17:33
@charlesvien charlesvien force-pushed the 01-15-implement_terminal_layout_setting_breaking_to_an_empty_dropdown branch 2 times, most recently from c845e60 to dedd099 Compare January 16, 2026 17:47
@charlesvien charlesvien changed the base branch from 01-15-implement_ability_to_choose_key_combination_to_send_messages to graphite-base/519 January 16, 2026 17:49
@charlesvien charlesvien force-pushed the 01-15-implement_terminal_layout_setting_breaking_to_an_empty_dropdown branch from dedd099 to 645779d Compare January 16, 2026 17:49
@charlesvien charlesvien changed the base branch from graphite-base/519 to 01-15-implement_feature_to_auto_convert_long_text_to_attachments_on_paste January 16, 2026 17:49
@charlesvien charlesvien force-pushed the 01-15-implement_terminal_layout_setting_breaking_to_an_empty_dropdown branch from 645779d to b97adfe Compare January 16, 2026 17:53
@charlesvien charlesvien force-pushed the 01-15-implement_feature_to_auto_convert_long_text_to_attachments_on_paste branch 2 times, most recently from 73a85a6 to cc849f4 Compare January 16, 2026 17:59
@charlesvien charlesvien force-pushed the 01-15-implement_terminal_layout_setting_breaking_to_an_empty_dropdown branch from b97adfe to f8551fd Compare January 16, 2026 17:59
@charlesvien charlesvien changed the base branch from 01-15-implement_feature_to_auto_convert_long_text_to_attachments_on_paste to graphite-base/519 January 16, 2026 21:42
@charlesvien charlesvien force-pushed the 01-15-implement_terminal_layout_setting_breaking_to_an_empty_dropdown branch from f8551fd to 12124e6 Compare January 16, 2026 21:42
@charlesvien charlesvien changed the base branch from graphite-base/519 to 01-15-fix_file_changes_color_mismatch January 16, 2026 21:42
@charlesvien charlesvien changed the base branch from 01-15-fix_file_changes_color_mismatch to graphite-base/519 January 16, 2026 21:43
@charlesvien Graphite App
Copy link
Contributor Author

charlesvien commented Jan 16, 2026 •
edited
Loading

Merge activity

  • Jan 16, 9:43 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 16, 10:04 PM UTC: Graphite couldn't merge this pull request because a downstack PR fix: Fix file changes color mismatch #516 failed to merge.
  • Jan 16, 11:52 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 16, 11:56 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jan 16, 11:58 PM UTC: @charlesvien merged this pull request with Graphite.

@charlesvien charlesvien force-pushed the 01-15-implement_terminal_layout_setting_breaking_to_an_empty_dropdown branch from 12124e6 to 255945f Compare January 16, 2026 23:52
@charlesvien charlesvien changed the base branch from graphite-base/519 to main January 16, 2026 23:54
@charlesvien charlesvien force-pushed the 01-15-implement_terminal_layout_setting_breaking_to_an_empty_dropdown branch from 255945f to 7e73d2e Compare January 16, 2026 23:55
@charlesvien charlesvien merged commit 665af64 into main Jan 16, 2026
12 checks passed
@charlesvien charlesvien deleted the 01-15-implement_terminal_layout_setting_breaking_to_an_empty_dropdown branch January 16, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanlab jonathanlab jonathanlab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charlesvien @jonathanlab