Refresh diagnostics for open PowerShell docs#5402
Open
mdaneri wants to merge 2 commits intoPowerShell:mainfrom
Open
Refresh diagnostics for open PowerShell docs#5402mdaneri wants to merge 2 commits intoPowerShell:mainfrom
mdaneri wants to merge 2 commits intoPowerShell:mainfrom
Conversation
Force re-analysis of open PowerShell documents after the language server starts. Adds DidOpenTextDocument and DidCloseTextDocument notification types and a refreshOpenPowerShellDocumentDiagnostics() helper that filters open documents (powershell, file/untitled), logs the action, and sends didClose followed by didOpen (including languageId, version and text) to the language client. The method is invoked after the session reports it has started; it no-ops if the client isn't running or there are no matching open documents.
There was a problem hiding this comment.
Pull request overview
This PR addresses false diagnostics that appear when PowerShell documents are initially opened before the language server is fully initialized. The solution refreshes analysis for all open PowerShell documents once the language client reaches the Running state.
Changes:
- Added custom notification types for
textDocument/didOpenandtextDocument/didClose - Implemented
refreshOpenPowerShellDocumentDiagnostics()method to replay close/open events for already-open PowerShell documents - Called the refresh method after the language client is confirmed running during session startup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prefix this.languageClient.sendNotification calls with the void operator to explicitly discard the returned Promise and avoid floating-promise/unused-Promise warnings. Applied to notifications sent for DidCloseTextDocumentNotificationType and DidOpenTextDocumentNotificationType when iterating open PowerShell documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Related Issue
Fixes #5381
Testing
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready