Skip to content

add Biomethanation #257

Open
BertoGBG wants to merge 4 commits intoPyPSA:masterfrom
BertoGBG:biomethanation_PR
Open

add Biomethanation #257
BertoGBG wants to merge 4 commits intoPyPSA:masterfrom
BertoGBG:biomethanation_PR

Conversation

@BertoGBG
Copy link
Contributor

Closes # (if applicable).

Changes proposed in this Pull Request

added biomethantion technology (biological methantion of CO2 with electrolytic H2). The technology is part of the DEA catalogue and it was added via compile_cost_assumptions.py

Checklist

  • [ Y] Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • [ Y] Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • [Y ] I consent to the release of this PR's code under the GPLv3 license.

df.index = df.index.str.replace(" Total Input", "_H2")

# Rename indices and update units
replacements = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the renames more consistent with the most commonly used names?

hydrogen-input
co2-input
electricity-input etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the names to the most commonly used names (eg. methane-output insect of Methane Output).
for the final DF and csv file.
Note that the index names set in biomethanation_dea (like "El-Input", "H-Output") (the lines you mentioned) are only used as search keys by str.contains() in the filtering at lines 2155–2204 and 2312–2340. They never appear in the final CSV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants