-
Notifications
You must be signed in to change notification settings - Fork 270
Ck moe bs splitk pr #3411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huaiguxu
wants to merge
9
commits into
develop
Choose a base branch
from
ck_moe_bs_splitk_pr
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ck moe bs splitk pr #3411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d132131 to
a738178
Compare
a738178 to
030cf6e
Compare
coderfeli
previously approved these changes
Dec 16, 2025
Contributor
coderfeli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
coderfeli
approved these changes
Dec 17, 2025
Collaborator
|
Hi @huaiguxu, please resolve the conflicts and make sure all CI tests are passing. |
Collaborator
|
Hi @coderfeli and @huaiguxu, please resolve conflicts and make sure CI passes or we'll close this PR. |
Contributor
|
Error importing due to merge conflicts – please reopen the PR on ROCm/rocm-libraries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add split-k support for a8w8_moe_blk gemm1 only.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
The change is due to low CU utilization in gemm1 decode stage with TP mode.