Conversation
maribethb
reviewed
Apr 10, 2026
| * @param input The Input to compute a description/context label for. | ||
| * @param lookback If true, will use fields on the previous row to compute a | ||
| * label for the given input if it has no fields itself. | ||
| * @returns An accessibility label for the given input, or undefined if one |
Contributor
There was a problem hiding this comment.
This doesn't match reality, should this method join the array and return it as string?
Contributor
Author
There was a problem hiding this comment.
Doing that loses some of the commas in the full block readout. I think I'd kind of prefer to have this always return a list, and not export it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9685
Proposed Changes
This PR adds basic support for adding ARIA roles and labels to blocks. It backports the existing behavior from the screenreader branch, with heavy refactoring to improve readability and maintainability.
Future Work
Labeling will be substantially improved by field subclasses customizing their labeling. Those changes will be automatically incorporated; this PR uses the newly-introduced APIs to get appropriate field labels.
Additionally, label generation should be tweaked once Inputs have support for overriding labeling to use those APIs.
When support for detailed readout keyboard shortcuts and "where am I" shortcuts are added, methods to compute labels for the full tree leading up to a block (specified in the design doc) should be added.