Bump rubocop-rspec from 3.6.0 to 3.9.0#723
Merged
zetter-rpf merged 7 commits intomainfrom Mar 19, 2026
Merged
Conversation
Test coverage90.05% line coverage reported by SimpleCov. |
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 3.6.0 to 3.9.0. - [Release notes](https://github.com/rubocop/rubocop-rspec/releases) - [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rspec@v3.6.0...v3.9.0) --- updated-dependencies: - dependency-name: rubocop-rspec dependency-version: 3.9.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
896694e to
1357a9a
Compare
This was causing a rubocop warning. Referring to classes in that don't match the filenames can break the autoloader.
Contributor
There was a problem hiding this comment.
Pull request overview
This Dependabot PR upgrades rubocop-rspec (and related RuboCop dependencies) and applies the resulting style-driven changes across specs and a couple of app files to keep the codebase compliant with updated cops.
Changes:
- Bump
rubocop-rspecfrom 3.6.0 to 3.9.0 (withrubocopand transitive lockfile updates). - Update specs to satisfy new/updated RSpec cops (e.g., avoid leaky locals, prefer namespaced constants, minor Ruby idioms).
- Tidy a couple of Ruby implementation details (e.g., closing file handles in
file_mime_type, namespacing job error classes).
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
spec/lib/profile_api_client_spec.rb |
Adjusts error payload hashes to match updated style expectations. |
spec/jobs/upload_job_spec.rb |
Updates exception expectation to match newly namespaced job error class. |
spec/features/class_member/creating_a_batch_of_class_members_spec.rb |
Replaces a leaky local with let to satisfy new RSpec cop behavior. |
spec/concepts/class_member/create_spec.rb |
Uses grep for class filtering in expectations. |
lib/tasks/test_seeds.rake |
Removes now-unnecessary RuboCop output disable/enable directives. |
Gemfile.lock |
Locks upgraded RuboCop/RSpec-lint related gems and transitive dependencies. |
app/models/filesystem_project.rb |
Ensures file_mime_type doesn’t leak file descriptors; adds a local RuboCop suppression for returning an open IO. |
app/jobs/upload_job.rb |
Moves custom exception classes under UploadJob namespace. |
app/jobs/create_students_job.rb |
Switches concurrency exception handling to use SchoolStudent::ConcurrencyExceededForSchool. |
app/dashboards/project_dashboard.rb |
Adjusts permitted attributes hash formatting. |
app/controllers/api/school_students_controller.rb |
Raises the namespaced concurrency exception in batch enqueueing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Previously a file may have been left open
A rubocop upgrade warned us about this issue. We should be closing the files here or in the filesystem_project class.
Having things defined in the top level of files that don't match the class names can break the autoloader and lead to odd behaviour. I've merged the two uses of ConcurrencyExceededForSchool errors since they both refer to students.
2dab651 to
0098e9e
Compare
zetter-rpf
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps rubocop-rspec from 3.6.0 to 3.9.0.
Release notes
Sourced from rubocop-rspec's releases.
Changelog
Sourced from rubocop-rspec's changelog.
Commits
f7aecf0Merge pull request #2151 from rubocop/release893a25bBump version to 3.9.091ad43dMerge pull request #2150 from kevinrobell-st/patch-1802b386Fix CHANGELOGa03e0c7Merge pull request #2149 from rubocop/ci-test-ruby-4.068f25d9Temporarily add irb to Gemfileb9e50b8CI: Test with Ruby 4.0b63bcd8Merge pull request #2148 from sucicfilip/fix-described-class-inside-eval278245aFix RSpec/DescribedClass to ignore *_eval and *_exec blocksca18f5eMerge pull request #2144 from rubocop/dont-use-ruby-versionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)