Skip to content

Bump rubocop-rspec from 3.6.0 to 3.9.0#723

Merged
zetter-rpf merged 7 commits intomainfrom
dependabot/bundler/rubocop-rspec-3.9.0
Mar 19, 2026
Merged

Bump rubocop-rspec from 3.6.0 to 3.9.0#723
zetter-rpf merged 7 commits intomainfrom
dependabot/bundler/rubocop-rspec-3.9.0

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 10, 2026

Bumps rubocop-rspec from 3.6.0 to 3.9.0.

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v3.9.0

  • Fix a false positive for RSpec/LeakyLocalVariable when variables are used only in example metadata (e.g., skip messages). (@​ydah)
  • Fix a false positive for RSpec/ScatteredSetup when the hook is defined inside a class method. (@​d4rky-pl)
  • Fix a false positive for RSpec/DescribedClass inside dynamically evaluated blocks (class_eval, module_eval, instance_eval, class_exec, module_exec, instance_exec). (@​sucicfilip)
  • Add new cop RSpec/Output. (@​kevinrobell-st)

RuboCop RSpec v3.8.0

  • Add new cop RSpec/LeakyLocalVariable. (@​lovro-bikic)
  • Bump RuboCop requirement to +1.81. (@​ydah)
  • Fix a false positive for RSpec/LetSetup when let! used in outer scope. (@​ydah)
  • Fix a false positive for RSpec/ReceiveNever cop when allow(...).to receive(...).never. (@​ydah)
  • Fix detection of nameless doubles with methods in RSpec/VerifiedDoubles. (@​ushi-as)
  • Improve an offense message for RSpec/RepeatedExample cop. (@​ydah)
  • Let RSpec/SpecFilePathFormat leverage ActiveSupport inflections when configured. (@​corsonknowles, @​bquorning)

RuboCop RSpec v3.7.0

  • Mark RSpec/IncludeExamples as SafeAutoCorrect: false. (@​yujideveloper)
  • Fix a false positive for RSpec/LeakyConstantDeclaration when defining constants in explicit namespaces. (@​naveg)
  • Add support for error matchers (raise_exception and raise_error) to RSpec/Dialect. (@​lovro-bikic)
  • Don't register offenses for RSpec/DescribedClass within Data.define blocks. (@​lovro-bikic)
  • Add autocorrection support for RSpec/IteratedExpectation for single expectations. (@​lovro-bikic)
  • Exclude all cops from inspecting factorybot files, except if explicitly included. (@​Mth0158)
  • Fix a false positive for RSpec/ExcessiveDocstringSpacing when receivers are not RSpec methods. (@​ydah)
Changelog

Sourced from rubocop-rspec's changelog.

3.9.0 (2026-01-07)

  • Fix a false positive for RSpec/LeakyLocalVariable when variables are used only in example metadata (e.g., skip messages). ([@​ydah])
  • Fix a false positive for RSpec/ScatteredSetup when the hook is defined inside a class method. ([@​d4rky-pl])
  • Fix a false positive for RSpec/DescribedClass inside dynamically evaluated blocks (class_eval, module_eval, instance_eval, class_exec, module_exec, instance_exec). ([@​sucicfilip])
  • Add new cop RSpec/Output. ([@​kevinrobell-st])

3.8.0 (2025-11-12)

  • Add new cop RSpec/LeakyLocalVariable. ([@​lovro-bikic])
  • Bump RuboCop requirement to +1.81. ([@​ydah])
  • Fix a false positive for RSpec/LetSetup when let! used in outer scope. ([@​ydah])
  • Fix a false positive for RSpec/ReceiveNever cop when allow(...).to receive(...).never. ([@​ydah])
  • Fix detection of nameless doubles with methods in RSpec/VerifiedDoubles. ([@​ushi-as])
  • Improve an offense message for RSpec/RepeatedExample cop. ([@​ydah])
  • Let RSpec/SpecFilePathFormat leverage ActiveSupport inflections when configured. ([@​corsonknowles], [@​bquorning])

3.7.0 (2025-09-01)

  • Mark RSpec/IncludeExamples as SafeAutoCorrect: false. ([@​yujideveloper])
  • Fix a false positive for RSpec/LeakyConstantDeclaration when defining constants in explicit namespaces. ([@​naveg])
  • Add support for error matchers (raise_exception and raise_error) to RSpec/Dialect. ([@​lovro-bikic])
  • Don't register offenses for RSpec/DescribedClass within Data.define blocks. ([@​lovro-bikic])
  • Add autocorrection support for RSpec/IteratedExpectation for single expectations. ([@​lovro-bikic])
  • Exclude all cops from inspecting factorybot files, except if explicitly included. ([@​Mth0158])
  • Fix a false positive for RSpec/ExcessiveDocstringSpacing when receivers are not RSpec methods. ([@​ydah])
Commits
  • f7aecf0 Merge pull request #2151 from rubocop/release
  • 893a25b Bump version to 3.9.0
  • 91ad43d Merge pull request #2150 from kevinrobell-st/patch-1
  • 802b386 Fix CHANGELOG
  • a03e0c7 Merge pull request #2149 from rubocop/ci-test-ruby-4.0
  • 68f25d9 Temporarily add irb to Gemfile
  • b9e50b8 CI: Test with Ruby 4.0
  • b63bcd8 Merge pull request #2148 from sucicfilip/fix-described-class-inside-eval
  • 278245a Fix RSpec/DescribedClass to ignore *_eval and *_exec blocks
  • ca18f5e Merge pull request #2144 from rubocop/dont-use-ruby-version
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update ruby code labels Mar 10, 2026
Copilot AI review requested due to automatic review settings March 10, 2026 09:24
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update ruby code labels Mar 10, 2026
@dependabot dependabot bot review requested due to automatic review settings March 10, 2026 09:24
@cla-bot cla-bot bot added the cla-signed label Mar 10, 2026
@github-actions
Copy link

github-actions bot commented Mar 10, 2026

Test coverage

90.05% line coverage reported by SimpleCov.
Run: https://github.com/RaspberryPiFoundation/editor-api/actions/runs/23288292306

Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 3.6.0 to 3.9.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v3.6.0...v3.9.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-version: 3.9.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Copilot AI review requested due to automatic review settings March 19, 2026 08:43
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rspec-3.9.0 branch from 896694e to 1357a9a Compare March 19, 2026 08:43
@dependabot dependabot bot review requested due to automatic review settings March 19, 2026 08:43
This was causing a rubocop warning. Referring to classes in that don't match the filenames can break the autoloader.
Copilot AI review requested due to automatic review settings March 19, 2026 09:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This Dependabot PR upgrades rubocop-rspec (and related RuboCop dependencies) and applies the resulting style-driven changes across specs and a couple of app files to keep the codebase compliant with updated cops.

Changes:

  • Bump rubocop-rspec from 3.6.0 to 3.9.0 (with rubocop and transitive lockfile updates).
  • Update specs to satisfy new/updated RSpec cops (e.g., avoid leaky locals, prefer namespaced constants, minor Ruby idioms).
  • Tidy a couple of Ruby implementation details (e.g., closing file handles in file_mime_type, namespacing job error classes).

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
spec/lib/profile_api_client_spec.rb Adjusts error payload hashes to match updated style expectations.
spec/jobs/upload_job_spec.rb Updates exception expectation to match newly namespaced job error class.
spec/features/class_member/creating_a_batch_of_class_members_spec.rb Replaces a leaky local with let to satisfy new RSpec cop behavior.
spec/concepts/class_member/create_spec.rb Uses grep for class filtering in expectations.
lib/tasks/test_seeds.rake Removes now-unnecessary RuboCop output disable/enable directives.
Gemfile.lock Locks upgraded RuboCop/RSpec-lint related gems and transitive dependencies.
app/models/filesystem_project.rb Ensures file_mime_type doesn’t leak file descriptors; adds a local RuboCop suppression for returning an open IO.
app/jobs/upload_job.rb Moves custom exception classes under UploadJob namespace.
app/jobs/create_students_job.rb Switches concurrency exception handling to use SchoolStudent::ConcurrencyExceededForSchool.
app/dashboards/project_dashboard.rb Adjusts permitted attributes hash formatting.
app/controllers/api/school_students_controller.rb Raises the namespaced concurrency exception in batch enqueueing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Previously a file may have been left open
A rubocop upgrade warned us about this issue. We should be closing the files here or in the filesystem_project class.
Having things defined in the top level of files that don't match the class names can break the autoloader and lead to odd behaviour.

I've merged the two uses of ConcurrencyExceededForSchool errors since they both refer to students.
@zetter-rpf zetter-rpf force-pushed the dependabot/bundler/rubocop-rspec-3.9.0 branch from 2dab651 to 0098e9e Compare March 19, 2026 09:26
@zetter-rpf zetter-rpf merged commit 683efe3 into main Mar 19, 2026
6 checks passed
@zetter-rpf zetter-rpf deleted the dependabot/bundler/rubocop-rspec-3.9.0 branch March 19, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed dependencies Pull requests that update a dependency file ruby Pull requests that update ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants