Merged
Conversation
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
Test coverage89.81% line coverage reported by SimpleCov. |
dependabot
bot
force-pushed
the
dependabot/bundler/good_job-4.13.3
branch
from
959072c to
4f8af79
Compare
Bumps [good_job](https://github.com/bensheldon/good_job) from 4.11.2 to 4.13.3. - [Release notes](https://github.com/bensheldon/good_job/releases) - [Changelog](https://github.com/bensheldon/good_job/blob/main/CHANGELOG.md) - [Commits](bensheldon/good_job@v4.11.2...v4.13.3) --- updated-dependencies: - dependency-name: good_job dependency-version: 4.13.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
By running `bin/rails g good_job:update` This isn't required, but is suggested in the good job readme and may improve performance.
zetter-rpf
force-pushed
the
dependabot/bundler/good_job-4.13.3
branch
from
447438f to
44c192a
Compare
zetter-rpf
approved these changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Rails app’s background job infrastructure by bumping the good_job gem to v4.13.3 and aligning the database schema (indexes) with the newer GoodJob release requirements.
Changes:
- Bump
good_jobfrom4.11.2to4.13.3(and update related transitive gems inGemfile.lock). - Add concurrent index migrations for
good_jobs(concurrency_key, created_at,job_class, and a revisedfinished_atcleanup index). - Update
db/schema.rbto reflect the new/updated indexes.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| db/schema.rb | Updates schema version and GoodJob-related indexes to match new migrations. |
| db/migrate/20260319084430_add_index_good_jobs_concurrency_key_created_at.rb | Adds concurrent composite index for concurrency-based lookups. |
| db/migrate/20260319084431_add_index_good_jobs_job_class.rb | Adds concurrent index on job_class. |
| db/migrate/20260319084432_add_index_good_jobs_finished_at_for_cleanup.rb | Adds a new partial finished_at index optimized for cleanup queries. |
| db/migrate/20260319084433_remove_extraneous_finished_at_index.rb | Drops the older finished_at index variant. |
| Gemfile | Updates good_job dependency constraint to ~> 4.13. |
| Gemfile.lock | Locks good_job v4.13.3 and updates dependent gems accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+6
to
+16
| def change | ||
| reversible do |dir| | ||
| dir.up do | ||
| # Ensure this incremental update migration is idempotent | ||
| # with monolithic install migration. | ||
| return unless connection.index_exists? :good_jobs, [:finished_at], name: :index_good_jobs_jobs_on_finished_at | ||
| end | ||
| end | ||
|
|
||
| remove_index :good_jobs, [:finished_at], where: "retried_good_job_id IS NULL AND finished_at IS NOT NULL", name: :index_good_jobs_jobs_on_finished_at, algorithm: :concurrently | ||
| end |
Comment on lines
+11
to
+15
| return if connection.index_exists? :good_jobs, [:concurrency_key, :created_at] | ||
| end | ||
| end | ||
|
|
||
| add_index :good_jobs, [:concurrency_key, :created_at], algorithm: :concurrently |
Comment on lines
+7
to
+16
| reversible do |dir| | ||
| dir.up do | ||
| # Ensure this incremental update migration is idempotent | ||
| # with monolithic install migration. | ||
| return if connection.index_exists? :good_jobs, :job_class | ||
| end | ||
| end | ||
|
|
||
| add_index :good_jobs, :job_class, algorithm: :concurrently | ||
| end |
Comment on lines
+7
to
+16
| reversible do |dir| | ||
| dir.up do | ||
| # Ensure this incremental update migration is idempotent | ||
| # with monolithic install migration. | ||
| return if connection.index_exists? :good_jobs, [:finished_at], name: :index_good_jobs_jobs_on_finished_at_only | ||
| end | ||
| end | ||
|
|
||
| add_index :good_jobs, [:finished_at], where: "finished_at IS NOT NULL", name: :index_good_jobs_jobs_on_finished_at_only, algorithm: :concurrently | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps good_job from 4.11.2 to 4.13.3.
Release notes
Sourced from good_job's releases.
... (truncated)
Changelog
Sourced from good_job's changelog.
... (truncated)
Commits
438d139Release good_job v4.13.31ea935eFix search_text scope using mismatched text search configurations (#1716)0f2551aUpdate suggested Puma config in README (#1713)db82664--daemonize no longer changes working directory, fixes relative paths (#1714)7f4f97fRelease good_job v4.13.2ce46a9fCheck for graceful shutdown inside job cleanup (#1711)f183d8dAdd test for Migration generator with custom migration path (#1709)e1362beAdd Ruby 4.0 to CI (#1705)e5d7f5bSupport Rails 8.2-dev `enqueue_after_transaction_commit by deferring framewor...ece13efBump actions/upload-artifact from 5 to 6 (#1703)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)