Skip to content

1187: add upload button to project bar#1387

Merged
DNR500 merged 6 commits intomainfrom
1187-add-upload-button-to-project-bar
Mar 18, 2026
Merged

1187: add upload button to project bar#1387
DNR500 merged 6 commits intomainfrom
1187-add-upload-button-to-project-bar

Conversation

@DNR500
Copy link
Contributor

@DNR500 DNR500 commented Mar 16, 2026

issue: 1187

This is a follow up to the addition of the upload button to the code editors save and download panel for scratch.

This adds the upload button to the project panel ONLY for scratch projects

Screenshot 2026-03-16 at 19 56 17

Copilot AI review requested due to automatic review settings March 16, 2026 19:00
@DNR500 DNR500 temporarily deployed to previews/1387/merge March 16, 2026 19:00 — with GitHub Actions Inactive
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Upload action to the top project bar UI, scoped to Scratch projects, as a follow-up to adding Upload in the Scratch save/download panel.

Changes:

  • Render an UploadButton in ProjectBar when the loaded project is Scratch (code_editor_scratch).
  • Extend ProjectBar unit tests to assert Upload visibility rules (hidden generally, shown for Scratch).
  • Add header.upload English translation string.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/components/ProjectBar/ProjectBar.jsx Adds conditional rendering of the Upload button for Scratch projects in the project bar.
src/components/ProjectBar/ProjectBar.test.js Adds assertions around Upload button visibility across project/login states, including Scratch.
public/translations/en.json Adds header.upload translation string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@zetter-rpf zetter-rpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some suggestions

@DNR500 DNR500 temporarily deployed to previews/1387/merge March 17, 2026 14:07 — with GitHub Actions Inactive
@DNR500 DNR500 temporarily deployed to previews/1387/merge March 17, 2026 14:39 — with GitHub Actions Inactive
@DNR500 DNR500 force-pushed the 1187-add-upload-button-to-project-bar branch from 2450b25 to 987978d Compare March 17, 2026 15:40
@DNR500 DNR500 temporarily deployed to previews/1387/merge March 17, 2026 15:40 — with GitHub Actions Inactive
@DNR500 DNR500 force-pushed the 1187-add-upload-button-to-project-bar branch from 987978d to 826e110 Compare March 17, 2026 18:04
@DNR500 DNR500 merged commit df17887 into main Mar 18, 2026
7 checks passed
@DNR500 DNR500 deleted the 1187-add-upload-button-to-project-bar branch March 18, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants