fix: bump qdrant client to v1.17.0 and disable version compatibility check#11886
Draft
roomote-v0[bot] wants to merge 1 commit intomainfrom
Draft
fix: bump qdrant client to v1.17.0 and disable version compatibility check#11886roomote-v0[bot] wants to merge 1 commit intomainfrom
roomote-v0[bot] wants to merge 1 commit intomainfrom
Conversation
…check - Bumps @qdrant/js-client-rest from ^1.14.0 to ^1.17.0 to support Qdrant server v1.16.x+ - Sets checkCompatibility: false in QdrantClient constructor to prevent future client/server version mismatch errors when users run newer Qdrant server versions Closes #11885
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #11885
Description
This PR attempts to address Issue #11885. Feedback and guidance are welcome.
Two changes to prevent Qdrant client/server version incompatibility errors:
@qdrant/js-client-restfrom^1.14.0to^1.17.0-- fixes the immediate incompatibility with Qdrant server v1.16.3+checkCompatibility: falsein bothQdrantClientconstructor call sites inqdrant-client.ts-- prevents this class of breakage from recurring when users run a newer Qdrant server version that the client has not yet been updated to matchThe Qdrant JS client enforces that the minor version difference between client and server must not exceed 1. By disabling this check, we avoid breaking users who pull the latest Qdrant Docker image before the client package catches up. The underlying REST API remains backward-compatible across these minor versions, so disabling the check is safe.
Test Procedure
qdrant-client.spec.tspass with the updated assertions that now expectcheckCompatibility: falsecd src && pnpm vitest run services/code-index/vector-store/__tests__/qdrant-client.spec.tsPre-Submission Checklist
Interactively review PR in Roo Code Cloud