Conversation
RaymondLi0
reviewed
Sep 17, 2025
Contributor
RaymondLi0
left a comment
There was a problem hiding this comment.
Very nice!
Didn't have a detailed look at this yet. But running the tests/models/test_checkpoint tests is a good way to test the conversion and the modeling file. For this you can add a new model config in tests/utils/model_configs.py that would use your new nm2 block. I can help for this if needed
fast_llm/layers/ssm/mamba2.py
Outdated
| self._local_xb_size = xb_dim.size | ||
|
|
||
| state_size = tensor_space[SSMDimNames.state].size | ||
| div(self._local_inner_size, state_size) |
Contributor
Author
There was a problem hiding this comment.
Addressed, added model for test, the tests seem to pass.
pytest tests/models/test_checkpoint.py --models hybrid_nm2
....
1 failed, 23 passed, 219 skipped, 34 warnings in 45.57s
Not sure if the failed one (tests/models/test_checkpoint.py::test_save_and_load_in_parallel[hybrid_nm2]@dependency_group_3) is expected to fail (it fails on previous mamba models as well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mamba2 implementation as in nemotron h. This also uses correct mamba2 kernels.
Motivation:
TODOs:
🔍 Type of change
Select all that apply:
📝 Changes
List the key changes introduced in this PR:
✅ Checklist
Make sure the following tasks are completed before submitting the PR:
General
Dependencies and Configuration
Testing
Performance Impact
📊 Performance Impact Details
If there is any impact on performance, describe it and provide benchmark results, if applicable:
🗒️ Additional Notes
Include any additional context, information, or considerations here, such as known issues, follow-up tasks, or backward compatibility concerns.