Calculate the mode correctly, return the 'maximum' value in case of multiple modes.#96
Open
Megh-Thakkar wants to merge 2 commits intomainfrom
Open
Calculate the mode correctly, return the 'maximum' value in case of multiple modes.#96Megh-Thakkar wants to merge 2 commits intomainfrom
Megh-Thakkar wants to merge 2 commits intomainfrom
Conversation
Collaborator
Author
|
Since we are only creating dummy reports for compositional tasks, the mode validation correctly follows this now: https://github.com/ServiceNow/WorkArena/blob/main/src/browsergym/workarena/tasks/compositional/dash_do_base.py#L346, https://github.com/ServiceNow/WorkArena/blob/main/src/browsergym/workarena/tasks/compositional/dash_do_base.py#L477 |
aldro61
requested changes
Aug 27, 2025
Collaborator
aldro61
left a comment
aldro61
left a comment
There was a problem hiding this comment.
@Megh-Thakkar for the cheat function, it's ok to use the max value as tiebreaker and just use the largest of the modes. However, for the validation function, we must accept any value that is a valid mode. You should move it to its one condition case, just like max/min and make sure you allow any number that is a valid mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#94