Use native FormData for bulk mutation variable file uploads#6756
Merged
jordanverasamy merged 1 commit intomainfrom Jan 14, 2026
Merged
Use native FormData for bulk mutation variable file uploads#6756jordanverasamy merged 1 commit intomainfrom
FormData for bulk mutation variable file uploads#6756jordanverasamy merged 1 commit intomainfrom
Conversation
The form-data package triggers a deprecation warning in node-fetch 3.x when passed as a request body. Switch to native FormData + Blob for the staged upload in bulk operations to avoid the warning. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
jordanverasamy
changed the title
FormData for bulk operation uploads
jordanverasamy
changed the title
FormData for bulk operation uploadsFormData for bulk operation staged file uploads
jordanverasamy
changed the title
FormData for bulk operation staged file uploadsFormData for bulk mutation variable file uploads
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3635 tests passing in 1426 suites. Report generated by 🧪jest coverage report action from f08eeb4 |
alexanderMontague
approved these changes
Jan 14, 2026
| } from '../../api/graphql/bulk-operations/generated/staged-uploads-create.js' | ||
| import {adminRequestDoc} from '@shopify/cli-kit/node/api/admin' | ||
| import {AdminSession} from '@shopify/cli-kit/node/session' | ||
| import {formData, fetch} from '@shopify/cli-kit/node/http' |
Contributor
There was a problem hiding this comment.
Can we remove this package from cli-kit now? I'd love to see a follow up PR if that is the case, reducing the bundle! Thanks
Contributor
Author
There was a problem hiding this comment.
Actually yeah :) Claude did that at first, but I asked him to minimize the diff and make this PR smaller, because I wasn't sure if removing it entirely was productive. I can absolutely do that in a follow-up!
Contributor
Author
There was a problem hiding this comment.
Aw, looks like we can't actually remove form-data from cli-kit yet.
I started sketching out the PR to fully remove it (link), but I discovered @shopify/oxygen-cli still imports formData from @shopify/cli-kit/node/http. (See here.)
We'd need to update oxygen-cli to use native FormData first, then revisit this. 😭
szluzero
approved these changes
Jan 14, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
…loads Use native `FormData` for bulk mutation variable file uploads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small improvement related to https://github.com/shop/issues-api-foundations/issues/1047. Found it while testing the command looking for bugs (https://github.com/shop/issues-api-foundations/issues/1081).
Summary
The
form-datanpm package triggers a deprecation warning when passed as a request body to node-fetch 3.x. This PR fixes it by switching bulk operation file uploads to use nativeFormData+Blobinstead of theform-datapackage.Tophatting
On
main, running a bulk mutation:On this branch: