Never return finished results when running app bulk execute without --watch
#6773
+81
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3656 tests passing in 1428 suites. Report generated by 🧪jest coverage report action from 08c7d1a |
ericlee878
approved these changes
Jan 16, 2026
Contributor
ericlee878
left a comment
ericlee878
left a comment
There was a problem hiding this comment.
Successfully tophatted 😀
jordanverasamy
changed the title
app bulk execute without --watch
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-api-foundations/issues/1295.
Currently, when we do our initial couple polls to make sure the bulk op is running as expected, if it finishes within that window (which would be super fast), we just immediately print the output.
WHAT is this pull request doing?
If a small bulk operation completes during the short poll window, we now say "bulk operation running" instead of "bulk operation complete", even though it is complete. This is a bit odd, but we have decided it is desirable behavior because it guarantees consistency -- whether the job is small or large, the output will be the same, which is helpful for scripting.
How to test your changes?
Try running a very small mutation, like for example this one:
You should see "Bulk operation is running" now, instead of "Bulk operation succeeded".