This repository was archived by the owner on Mar 7, 2018. It is now read-only.
remove direct dependency on thin as the rack implementation#183
Closed
tempredirect wants to merge 1 commit intoShopify:masterfrom
Closed
remove direct dependency on thin as the rack implementation#183tempredirect wants to merge 1 commit intoShopify:masterfrom
tempredirect wants to merge 1 commit intoShopify:masterfrom
Conversation
the main reason for this is to allow compatibility with jruby as thin is not really compatible out of the box with jruby.
Contributor
|
I like this. Giving users the ability to use the app server of their choice is a great addition. Because of the breaking changes it'll have to be part of a 2.0.0 release though, so I may not merge it in for a while. It will also be dependent on fixing the |
|
+1 |
3 similar comments
|
+1 |
|
+1 |
Contributor
|
+1 |
Contributor
|
This PR can be closed as it is superseded by #427 -- hopefully that one is merged soon. |
Member
|
Yeah, moving all discussion to #427 for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the main reason for this is to allow compatibility with jruby as thin is not really compatible out of the box with jruby.
the change basically removes thin from the dashing.gemspec file and moves it to the dashboard's Gemfile where it is wrapped in a
platform :rubyblock and instead of using 'thin start' it uses 'rackup' to start the server.initial problems:
rackup, guess may have to use the rack.pid file and kill the process