Open
Conversation
charlespwd
force-pushed
the
cp-one-parser
branch
from
cf8f143 to
07531a7
Compare
charlespwd
force-pushed
the
cp-one-parser
branch
from
07531a7 to
c12fc1b
Compare
karreiro
approved these changes
Dec 2, 2025
Contributor
karreiro
left a comment
karreiro
left a comment
There was a problem hiding this comment.
Thank you for this PR, @charlespwd! Great stuff! I've left some comments that may be applied in follow-up PRs.
karreiro
approved these changes
Dec 3, 2025
Contributor
karreiro
left a comment
karreiro
left a comment
There was a problem hiding this comment.
Thank you for the changes, @charlespwd!
TWiStErRob
reviewed
Dec 17, 2025
| * As tag argument `{% render 'snip', enabled: a or b %}` | ||
| * As conditional tag argument `{% if cond %}` (extending previous behaviour) | ||
| * (TODO) Add support for subexpression prioritization and associativity | ||
| * In ascending order of priority: |
Contributor
Author
There was a problem hiding this comment.
Deep pull :D It's not in scope (yet?), but, unlike last time, we wouldn't be held back by lax anymore and the system would leave space for a UnaryExpression node with an operator and an expression.
charlespwd
force-pushed
the
cp-one-parser
branch
from
d22ead1 to
3a675a4
Compare
charlespwd
force-pushed
the
cp-one-parser
branch
2 times, most recently
from
cf8fdf6 to
d0ccab5
Compare
charlespwd
force-pushed
the
cp-one-parser
branch
from
d0ccab5 to
f4a5454
Compare
charlespwd
force-pushed
the
cp-one-parser
branch
from
9907965 to
f4a5454
Compare
This branch gates lax-mode-only specs behind lax_parsing feature: - shopify_production_recordings: 22 specs - liquid_ruby: 16 specs - basics: error regex updated Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers, please note base branch to PR.
In this PR
Environment.error_modelax_parse,strict_parse+:warnerror modestrict2_parsetoparse_markupwarningssystem