Skip to content

Add defaultLibrary semantic token selector aliases#754

Open
a-lavis wants to merge 1 commit intoShopify:mainfrom
a-lavis:add-defaultlibrary-semantic-selector
Open

Add defaultLibrary semantic token selector aliases#754
a-lavis wants to merge 1 commit intoShopify:mainfrom
a-lavis:add-defaultlibrary-semantic-selector

Conversation

@a-lavis
Copy link

@a-lavis a-lavis commented Mar 13, 2026

What

Updates the Spinel Light/Dark themes to support: Shopify/ruby-lsp#4005

In the future, we can consider removing the variable.default_library selector, but I think its worth keeping for now for backwards compatibility until everyone has updated to a new version of ruby-lsp with the above change.

Why

See the above PR's description for more details.

@a-lavis a-lavis marked this pull request as ready for review March 13, 2026 18:00
@a-lavis a-lavis requested a review from a team as a code owner March 13, 2026 18:00
@a-lavis
Copy link
Author

a-lavis commented Mar 13, 2026

Just signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant