Fix Windows stable build initial checkout and update maintenance docs from overload to bluestreak#83
Open
ebrahimebrahim wants to merge 3 commits intoSlicer:mainfrom
Open
Fix Windows stable build initial checkout and update maintenance docs from overload to bluestreak#83ebrahimebrahim wants to merge 3 commits intoSlicer:mainfrom
ebrahimebrahim wants to merge 3 commits intoSlicer:mainfrom
Conversation
The fastdel function used robocopy /purge to empty a directory but never removed the directory itself. This left empty directories that caused ctest to skip initial checkout (clone) and attempt an update on an empty directory instead, failing silently. Adding rmdir after the purge ensures the directory is fully removed so ctest correctly detects a missing source directory and performs a fresh clone. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CTest's CTEST_CHECKOUT_COMMAND splits the command string by spaces, so "C:/Program Files/Git/cmd/git.exe" breaks the clone command. Using the 8.3 short path (PROGRA~1) avoids the space issue. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Windows dashboard machine was renamed from overload to bluestreak. Update maintenance guides, Makefile, and paths accordingly: - overload → bluestreak, VNC → NoMachine - D:\D\ paths → C:\D\ (bluestreak uses C: drive) - C:\Python36-x64 → C:\Python37-x64 - girder_client-venv → girder-client-venv (actual name on disk) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After deleting the stable build on bluestreak due to annoying file permission issues while switching to user svc-bluestreak, running
bluestreak-vs2022-slicer_stable_package.batwas not working to create a fresh stable build. It turned to be due to the space in "Program Files" making the git clone command fail. It wasn't an issue for svc-dashboard because it always hadC:\D\S\S-0available from a previous build and so that clone command was not getting triggered.Now a fresh stable build seems to be running with this version of
bluestreak-vs2022-slicer_stable_package.bat.Had claude update stale references in the docs while I was at it.