Closed
Conversation
Update socket-patch dependency from v1.0.0 to v1.2.0, which includes: - Progress spinner for scan command - Improved test coverage This update addresses reviewer feedback in depscan PR #16387 regarding the socket-patch version mismatch. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Upgrade socket-patch from v1.2.0 to v2.0.0, now a native Rust binary - Rewrite patch command to spawn the platform-specific Rust binary directly instead of importing the Node.js runPatch() function - Map socket-cli environment variables to socket-patch env vars (SOCKET_API_URL, SOCKET_API_TOKEN, SOCKET_ORG_SLUG, etc.) - Add comprehensive patch command documentation to README with subcommand reference table and quick-start guide - Bump version to 1.1.58
- Add signal handling to cmd-patch.mts to properly propagate signals when child process is killed - Fix test snapshots to use <redacted> placeholders for machine-specific values (CLI version, token, org, cwd) - Add normalizeBanner() function to test utils to sanitize Socket CLI banner output - Include 'Received an unknown command: patch' line in cli.test.mts snapshot as it appears during test execution
mikolalysenko
force-pushed
the
feat/socket-patch-v2
branch
from
48d3c65 to
9c21ec1
Compare
Contributor
Author
|
Closing — these fixes are already included in #1103 (moved socket-patch to dependencies, added shell: constants.WIN32 for Windows, signal propagation, and restored test snapshots). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix signal propagation in
cmd-patchand sanitize environment-specific values in CLI test snapshots.The
cmd-patchcommand now correctly propagates signals from its child process, preventing silent exits when the child is killed by a signal. Test snapshots were updated to use<redacted>placeholders for paths, versions, and token info, and anormalizeBannerutility was added to ensure consistent test results across different environments.Note
Medium Risk
Switches
socket patchexecution from a Node wrapper to a spawned platform-specific binary and changes how env/exit/signal handling works, which can affect behavior across OSes. Dependency and lockfile updates add multiple optional native packages that may introduce install/runtime edge cases.Overview
Updates the CLI to v
1.1.58and upgrades@socketsecurity/socket-patchto2.0.0, pulling in platform-specific optional native binaries via the lockfile.Refactors
socket patchto resolve andspawnSyncthesocket-patchbin directly, mapping Socket CLI env vars to the binary’s expected env vars and propagating child exit codes/signals.Expands
README.mdwith asocket patchsubcommand reference + quick-start, and stabilizes CLI test snapshots by redacting banner/version/token/cwd values via a newnormalizeBannerhelper.Written by Cursor Bugbot for commit cbe0b68. This will update automatically on new commits. Configure here.