chore: replace fs.rm with safeDelete#1263
Open
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Open
chore: replace fs.rm with safeDelete#1263John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Conversation
CLAUDE.md forbids fs.rm / fs.rmSync / rm -rf in our code — safeDelete from @socketsecurity/lib/fs is the canonical wrapper. Fixes sync-checksums.mts (3 sites) and the setup-security-tools Claude hook (1 site).
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f0ccde5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.md forbids `fs.rm` / `fs.rmSync` / `rm -rf` in our code — use `safeDelete` from `@socketsecurity/lib/fs`.
Fixes:
Test plan
Note
Low Risk
Low risk refactor: only changes temp directory cleanup in two scripts, with no impact to core business logic beyond how deletions are performed.
Overview
Replaces recursive temp-directory cleanup using
fs.rm(..., { recursive: true })withsafeDeletefrom@socketsecurity/lib/fs.This updates cleanup paths in the
zizmorextraction flow (.claude/hooks/setup-security-tools/index.mts) and in the checksum sync script (packages/cli/scripts/sync-checksums.mts), including normal, error, andfinallycleanup branches.Reviewed by Cursor Bugbot for commit f0ccde5. Configure here.