Skip to content

Conversation

@bourgeoa
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 24, 2026 22:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dependencies in the folder-pane package, including peer dependencies and development dependencies. The changes reflect routine dependency maintenance to keep the project up-to-date with the latest versions of its tooling and runtime dependencies.

Changes:

  • Updated peer dependencies (solid-logic from ^4.0.0 to ^4.0.2, solid-ui from ^3.0.0 to ^3.0.3)
  • Updated development dependencies (Babel packages, ESLint packages, TypeScript, and related tooling)
  • Updated GitHub repository URLs from solid/folder-pane to SolidOS/folder-pane

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Updates peer dependencies (solid-logic, solid-ui), development dependencies (babel, eslint, typescript tooling), and GitHub organization references
package-lock.json Reflects the resolved versions and dependency trees for all updated packages, including transitive peer dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +45 to +46
"solid-logic": "^4.0.2",
"solid-ui": "^3.0.3"
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated peer dependencies (solid-logic ^4.0.2 and solid-ui ^3.0.3) introduce a Node.js version constraint that is not reflected in this package. The solid-ui 3.0.3 package depends on @noble/curves and @noble/hashes version 2.0.1, both of which require Node.js >= 20.19.0. However, this package does not specify an engines field in package.json to enforce this requirement. This could lead to runtime failures for users running on older Node.js versions. Consider adding an engines field specifying the minimum Node.js version required, such as "engines": {"node": ">= 20.19.0"}.

Copilot uses AI. Check for mistakes.
@bourgeoa bourgeoa merged commit 01a22d7 into main Jan 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant