-
Notifications
You must be signed in to change notification settings - Fork 48
milestone3m #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bourgeoa
wants to merge
14
commits into
main
Choose a base branch
from
milestone3m
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
milestone3m #598
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
57056d4
improved local dev
timea-solid 4f2c7e0
new outine structure, ts ignores
timea-solid 89c9c46
wired in environement in context and added left side menu
timea-solid d9e8c7e
updated pane-registry
timea-solid 4d9820b
merge main
timea-solid f8eb415
merge main
timea-solid 14c9481
updated codebase
timea-solid f4bdc44
fic CI
timea-solid eeb27e6
fix lint
timea-solid 9471402
register editProfileView only if it exists
b8d2e96
close to final design and calling components
timea-solid b70303a
small improvements and comments
timea-solid 554c862
rewired menu, better header event handling
timea-solid 782064c
Merge branch 'milestone2k' into milestone3m
timea-solid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -78,3 +78,25 @@ contacts (A VCARD Address Book, Group, Individual, Organization) can be handled | |||||
| pane. Any other pane which wants to deal with contacts can just use the pane within its own user interface. | ||||||
|
|
||||||
|  | ||||||
|
|
||||||
|
|
||||||
| ## Generative AI usage | ||||||
| The SolidOS team is using GitHub Copilot integrated in Visual Studio Code. | ||||||
| We have added comments in the code to make it explicit which parts are 100% written by AI. | ||||||
|
|
||||||
| ### Prompt usage hitory: | ||||||
| * Model Claude Opus 4.6: Initially solid-panes is loaded into a HTML shell form mashlib that looks like ... Also, an iFrame is rendered inside the <div class="TabulatorOutline" id="DummyUUID"> for “isolated pane rendering”. Analize the solid-panes code for what it uses from this HTML and suggest a new HTML structure which is mobile and accessibility friendly. Lets go ahead and make chnages in this code as suggested to accommodate the new databwroser HTML. | ||||||
|
|
||||||
| * Raptor mini: take a look how I wired the environement from mashlib into solid-panes. It is not quite right, can you suggest fixes? | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| * Raptor mini: Update the code to use the new solid-ui-header component. Keep in mind the log in and sign up are wired in specific ways. | ||||||
|
|
||||||
| * Auto: chnage the menu to fill up the menu items like in the code: async function getMenuItems (outliner: any) { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| const items = await outliner.getDashboardItems() | ||||||
| return items.map((element) => { | ||||||
| return { | ||||||
| label: element.label, | ||||||
| onclick: () => openDashboardPane(outliner, element.tabName || element.paneName) | ||||||
| } | ||||||
| }) | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.