Fixed named exports resolution with commonjs#314
Open
maneesht wants to merge 1 commit intoStarcounter-Jack:masterfrom
Open
Fixed named exports resolution with commonjs#314maneesht wants to merge 1 commit intoStarcounter-Jack:masterfrom
maneesht wants to merge 1 commit intoStarcounter-Jack:masterfrom
Conversation
gustawdaniel
approved these changes
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, when importing using CommonJS, node will resolve to
/index.js. However, this doesn't work when using named imports. By specifying the ESM module instead of the CommonJS module when using ESM, the resolution error goes away.This should fix #277