Conversation
|
Do you want to make a hotfix release for this? |
| if sys.version_info >= (3, 8, 0): | ||
| from typing import * # noqa: F401, F403 | ||
| except ImportError: | ||
| else: | ||
| from .typing_stubs import * # type: ignore # noqa: F401, F403 |
There was a problem hiding this comment.
Should it be something like this instead so that the Sublime Text typing depedency is used when installed?
if sys.version_info >= (3, 8, 0):
from typing import * # noqa: F401, F403
else:
try:
from typing import * # noqa: F401, F403
except ImportError:
from .typing_stubs import * # type: ignore # noqa: F401, F403Although I'm not sure what would be the point really. It would not change the runtime behavior and is not needed for pyright either.
There was a problem hiding this comment.
Probably not needed, and we've had issues with a similar approach with enum.
|
If you would want to ignore the diff --git a/pyrightconfig.json b/pyrightconfig.json
new file mode 100644
index 0000000..d8bd1c1
--- /dev/null
+++ b/pyrightconfig.json
@@ -0,0 +1,4 @@
+{
+ "pythonVersion": "3.8",
+ "reportWildcardImportFromLibrary": "none"
+}The |
|
Can we get this out? |
|
@Thom1729 can you? |
|
Do we not need a (hotfix) relase for it? |
|
If we can merge #166, we can release 1.6 and there's probably no need for a hotfix. If not, I can release a hotfix tonight or tomorrow. |
|
SGTM. |
Fix #171.