feat(async-batcher): make result a type parameter#64
Open
louneskmt wants to merge 1 commit intoTanStack:mainfrom
Open
feat(async-batcher): make result a type parameter#64louneskmt wants to merge 1 commit intoTanStack:mainfrom
louneskmt wants to merge 1 commit intoTanStack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d740d9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
I'm considering this PR and how to make the return types consistent across all async utils after #54 is done |
Author
|
Let me know if I can be of any further help! Once we agree on how to do it, I can take care of the implementation across all async utils, if you want to focus on some other stuff 👍 |
Member
|
I think we might want to start this PR over after all of the changes. There is room for improved type-safety here though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved
AsyncBatchertypings by making the batch function's return type a type parameter. The related properties and functions are now aware of the result type (lastResult,onSuccess). This changes a bit where to put the item type, initially as a type parameter (asyncBatcher<number>((items) => ...)to the function arguments directly (asyncBatcher((items: number[]) => ...).