test({react,preact}-query/useSuspenseQueries): add test for not suspending when all queries have fresh cached data by sukvvon · Pull Request #10202 · TanStack/query

sukvvon · 2026-03-01T17:44:30Z

🎯 Changes

Add a test to verify that useSuspenseQueries does not suspend when all queries already have fresh cached data.

When all queries have cached data within staleTime (min 1000ms in suspense mode), the component should:

Render immediately with cached data (no suspend)
Not trigger any background refetch (queryFn not called)

Added to both react-query and preact-query.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added test coverage for useSuspenseQueries to verify queries don't suspend or trigger background refetches when fresh cached data is already available.

…nding when all queries have fresh cached data

changeset-bot · 2026-03-01T17:44:34Z

⚠️ No Changeset found

Latest commit: f139851

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-01T17:44:46Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54d9fc8 and f139851.

📒 Files selected for processing (2)

packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx
packages/react-query/src/__tests__/useSuspenseQueries.test.tsx

📝 Walkthrough

Walkthrough

Test cases added to both preact-query and react-query packages verifying that useSuspenseQueries doesn't suspend or trigger refetches when all queries have fresh cached data available.

Changes

Cohort / File(s)	Summary
useSuspenseQueries Test Cases `packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx`, `packages/react-query/src/__tests__/useSuspenseQueries.test.tsx`	New test case "should not suspend and not refetch when all queries have fresh cached data" verifying that useSuspenseQueries returns cached data immediately without triggering suspense or background refetches when all queries have fresh data.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

refactor(preact-query/useQueries): remove unreachable 'willFetch' branch in suspense promise collection #10188 — Simplifies/removes unreachable suspense branch in preact-query that directly affects the control flow tested by these new test cases.
test(preact-query/useSuspenseQueries): add test for suspending only pending queries when some already have cached data #10133 — Adds complementary tests for useSuspenseQueries behavior with cached queries, verifying selective suspense when only some queries are fresh.

Suggested labels

package: react-query, package: preact-query

Suggested reviewers

TkDodo
manudeli

Poem

🐰 Fresh cache, no wait, no fetch from sight,
Suspense takes rest, data shines bright,
Twin packages tested, both stand tall,
When data is ready, no pause at all! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely describes the main change: adding a test for useSuspenseQueries behavior when all queries have fresh cached data.
Description check	✅ Passed	The description follows the template structure, includes clear explanation of the changes, confirms checklist items, and correctly marks the change as dev-only with no release impact.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-01T17:44:56Z

View your CI Pipeline Execution ↗ for commit f139851

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 31s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-01 17:49:07 UTC

pkg-pr-new · 2026-03-01T17:46:30Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10202

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10202

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10202

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10202

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10202

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10202

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10202

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10202

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10202

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10202

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10202

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10202

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10202

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10202

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10202

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10202

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10202

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10202

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10202

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10202

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10202

commit: a5c6333

test({react,preact}-query/useSuspenseQueries): add test for not suspe…

f139851

…nding when all queries have fresh cached data

github-actions bot added package: react-query package: preact-query labels Mar 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test({react,preact}-query/useSuspenseQueries): add test for not suspending when all queries have fresh cached data#10202

test({react,preact}-query/useSuspenseQueries): add test for not suspending when all queries have fresh cached data#10202
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:test/useSuspenseQueries-all-cached-data

sukvvon commented Mar 1, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Mar 1, 2026

Uh oh!

coderabbitai bot commented Mar 1, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud bot commented Mar 1, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Mar 1, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Mar 1, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Mar 1, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 1, 2026 •

edited

Loading

nx-cloud bot commented Mar 1, 2026 •

edited

Loading