Skip to content

fix(examples): remove stale delay slider reference from with-trpc example#6876

Merged
SeanCassiere merged 2 commits intoTanStack:mainfrom
sleitor:fix-6870
Mar 10, 2026
Merged

fix(examples): remove stale delay slider reference from with-trpc example#6876
SeanCassiere merged 2 commits intoTanStack:mainfrom
sleitor:fix-6870

Conversation

@sleitor
Copy link
Contributor

@sleitor sleitor commented Mar 10, 2026

Fixes #6870

Problem

The with-trpc example's index route contains the text:

To exaggerate async effects, play with the artificial request delay slider in the bottom-left corner.

This text was copied from the kitchen-sink example but the delay slider UI component was never added to the with-trpc example. There is no slider in the bottom-left corner.

Fix

Remove the stale sentence referencing the non-existent delay slider. The remaining text about preloading and route data caching sliders still refers to controls that don't exist either, but this was explicitly mentioned in the issue as the minimal/immediate fix.

Summary by CodeRabbit

  • Documentation
    • Removed explanatory guidance and a horizontal divider related to the request delay slider in the example UI.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fe610cb5-d279-47fe-9d45-c5d82876631c

📥 Commits

Reviewing files that changed from the base of the PR and between b44d9fb and 8493325.

📒 Files selected for processing (1)
  • examples/react/with-trpc/src/routes/index.tsx
💤 Files with no reviewable changes (1)
  • examples/react/with-trpc/src/routes/index.tsx

📝 Walkthrough

Walkthrough

Removed three lines (two explanatory sentences and a horizontal rule) from the With TRPC example that referenced an artificial request delay slider which does not exist; no logic or API changes were made.

Changes

Cohort / File(s) Summary
Documentation cleanup
examples/react/with-trpc/src/routes/index.tsx
Deleted two explanatory sentences and one horizontal rule referencing a non-existent "artificial request delay" slider; no code or export changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🥕 A rabbit read the docs tonight,
Saw a slider that wasn't in sight,
With a nibble and a hop so witty,
I trimmed the lines to keep it pretty,
Now the example's clear and light. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: removing the stale delay slider reference from the with-trpc example.
Linked Issues check ✅ Passed The PR addresses the requirements of issue #6870 by removing misleading text about non-existent sliders from the with-trpc example.
Out of Scope Changes check ✅ Passed The changes are limited to removing stale references from documentation text within the with-trpc example, directly addressing the linked issue scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 10, 2026

View your CI Pipeline Execution ↗ for commit 8493325

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 53s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-10 16:05:00 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 10, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6876

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6876

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6876

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6876

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6876

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6876

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6876

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6876

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6876

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6876

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6876

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6876

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6876

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6876

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6876

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6876

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6876

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6876

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6876

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6876

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6876

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6876

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6876

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6876

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6876

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6876

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6876

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6876

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6876

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6876

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6876

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6876

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6876

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6876

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6876

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6876

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6876

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6876

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6876

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6876

commit: 72fdc8b

@github-actions
Copy link

github-actions bot commented Mar 10, 2026

Bundle Size Benchmarks

  • Commit: d306d58a2116
  • Measured at: 2026-03-10T16:05:06.477Z
  • Baseline source: history:d306d58a2116
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.07 KiB 0 B (0.00%) 273.82 KiB 75.73 KiB ▁▁▁▁▁▁▁▆▆██
react-router.full 90.02 KiB 0 B (0.00%) 284.08 KiB 78.28 KiB ▁▁▁▁▁▁▁▇▇██
solid-router.minimal 36.39 KiB 0 B (0.00%) 109.01 KiB 32.66 KiB ▁▁▁▁▁▁▁▆▇██
solid-router.full 40.70 KiB 0 B (0.00%) 121.98 KiB 36.46 KiB ▁▁▁▁▁▁▁▅▆██
vue-router.minimal 52.24 KiB 0 B (0.00%) 149.06 KiB 46.90 KiB ▁▁▁▁▁▁▁▅▆██
vue-router.full 57.04 KiB 0 B (0.00%) 164.56 KiB 51.23 KiB ▁▁▁▁▁▁▁▅▆██
react-start.minimal 99.63 KiB 0 B (0.00%) 312.97 KiB 86.15 KiB ▁▁▁▁▁▁▁▅▅██
react-start.full 102.92 KiB 0 B (0.00%) 322.70 KiB 89.04 KiB ▁▁▁▁▁▁▁▇▇██
solid-start.minimal 48.70 KiB 0 B (0.00%) 146.60 KiB 43.10 KiB ▁▁▁▁▁▁▁▆▆██
solid-start.full 54.17 KiB 0 B (0.00%) 162.47 KiB 47.76 KiB ▁▁▁▁▁▁▁▅▆██

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 10, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing sleitor:fix-6870 (8493325) with main (d306d58)

Open in CodSpeed

@BrendanC23
Copy link

Thanks for the PR. There are also no sliders for controlling the preload state, so that text can be removed as well.

@sleitor
Copy link
Contributor Author

sleitor commented Mar 10, 2026

Done! Also removed the preload state slider text in the follow-up commit.

@SeanCassiere SeanCassiere merged commit 870cf28 into TanStack:main Mar 10, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs Examples] "With TRPC" example does not display sliders

3 participants