fix(examples): remove stale delay slider reference from with-trpc example#6876
fix(examples): remove stale delay slider reference from with-trpc example#6876SeanCassiere merged 2 commits intoTanStack:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoved three lines (two explanatory sentences and a horizontal rule) from the With TRPC example that referenced an artificial request delay slider which does not exist; no logic or API changes were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 8493325
☁️ Nx Cloud last updated this comment at |
Bundle Size Benchmarks
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better. |
|
Thanks for the PR. There are also no sliders for controlling the preload state, so that text can be removed as well. |
|
Done! Also removed the preload state slider text in the follow-up commit. |
Fixes #6870
Problem
The with-trpc example's index route contains the text:
This text was copied from the kitchen-sink example but the delay slider UI component was never added to the with-trpc example. There is no slider in the bottom-left corner.
Fix
Remove the stale sentence referencing the non-existent delay slider. The remaining text about preloading and route data caching sliders still refers to controls that don't exist either, but this was explicitly mentioned in the issue as the minimal/immediate fix.
Summary by CodeRabbit